Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 15, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR primarily focuses on reorganizing the code structure for the contract-ui components, moving several components to a new directory structure under apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/.

Detailed summary

  • Added import for ContractOverviewPage in page.tsx.
  • Moved NFTCards import in nfts-owned.tsx to a new path.
  • Updated NFTDetails to import NFTCards from the new location.
  • Added import for getAllRoleMembers in PermissionsTable.tsx.
  • Moved getAllRoleMembers import to a new path in PermissionsTable.tsx.
  • Added import for useContractFunctionSelectors in ContractChecklist.tsx.
  • Updated ContractChecklist to import useContractFunctionSelectors from the new path.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: 52d89ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2024 9:05pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 15, 2024 9:05pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 15, 2024 9:05pm
wallet-ui ⬜️ Skipped (Inspect) Oct 15, 2024 9:05pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 15, 2024
@MananTank MananTank changed the title Move contract overview page components to app router folder - No code changes Move contract overview page components to app router folder (No code changes) Oct 15, 2024
Copy link
Member Author

MananTank commented Oct 15, 2024

@MananTank MananTank marked this pull request as ready for review October 15, 2024 19:27
@codecov
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.30%. Comparing base (60a80ef) to head (52d89ce).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5038   +/-   ##
=======================================
  Coverage   45.30%   45.30%           
=======================================
  Files        1059     1059           
  Lines       54707    54707           
  Branches     3954     3954           
=======================================
  Hits        24786    24786           
  Misses      29230    29230           
  Partials      691      691           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 60a80ef
packages 40.24% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 15, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.77 KB (0%) 856 ms (0%) 3.6 s (+18.45% 🔺) 4.4 s
thirdweb (cjs) 102.62 KB (0%) 2.1 s (0%) 7.5 s (+25.36% 🔺) 9.5 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 300 ms (-22.79% 🔽) 396 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 181 ms (+71.9% 🔺) 191 ms
thirdweb/react (minimal + tree-shaking) 17.35 KB (0%) 347 ms (0%) 542 ms (-30.68% 🔽) 889 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 15, 2024

Merge activity

…changes) (#5038)

## Problem solved

Short description of the bug fixed or feature added

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the structure of the dashboard components by relocating several components to a new directory structure under `apps/dashboard/src/app/(dashboard)/(chain)/[chain_id]/[contractAddress]/overview/components`.

### Detailed summary
- Moved `NFTCards` import in `nfts-owned.tsx` to a new path.
- Updated `NFTCards` import in `NFTDetails.tsx` to the new path.
- Added `getAllRoleMembers` import in `PermissionsTable.tsx` from a new path.
- Moved `getAllRoleMembers` import to a new path in `PermissionsTable.tsx`.
- Added `useContractFunctionSelectors` import in `ContractChecklist.tsx` from a new path.
- Moved `useContractFunctionSelectors` import to a new path in `ContractChecklist.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 10-16-move_contract_overview_page_components_to_app_router_folder_-_no_code_changes branch from 22abbaf to 52d89ce Compare October 15, 2024 21:02
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 15, 2024 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 15, 2024 21:02 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 15, 2024 21:02 Inactive
@graphite-app graphite-app bot merged commit 52d89ce into main Oct 15, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 10-16-move_contract_overview_page_components_to_app_router_folder_-_no_code_changes branch October 15, 2024 21:07
@vercel vercel bot temporarily deployed to Production – wallet-ui October 15, 2024 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground October 15, 2024 21:07 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 October 15, 2024 21:07 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants